Box2<T> Box3<T> #194
Merged
Box2<T> Box3<T> #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Approved to merge, but part of me thinks that now that the structs are now immutable, is there any point in having the name of the methods be past tense? The pure overload of Translate was only called Translated to distinguish it from the former, however seeing as we no longer have Translate we could probably just rename Translated to Translate. What do you think?
|
Agreed! Will change |
|
Awesome :D |
Perksey
approved these changes
Jun 17, 2020
|
See #195 |
|
Ahaha nevermind, you opened a new pr before i typed my comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #190