Skip to content

missing dispose call #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nablabla opened this issue Nov 23, 2020 · 2 comments
Closed

missing dispose call #355

nablabla opened this issue Nov 23, 2020 · 2 comments
Labels
area-Windowing bug Something isn't working

Comments

@nablabla
Copy link

Summary

there seems to be missing a dispose call in the glfw events class

Steps to reproduce

look here, in the Dispose() method the event GlfwCallbacks.ScrollCallback Scroll was left out in
https://github.com/Ultz/Silk.NET/blob/master/src/Input/Silk.NET.Input.Desktop/GlfwEvents.cs

Comments

I am not sure
@nablabla nablabla added the bug Something isn't working label Nov 23, 2020
@Perksey
Copy link
Member

Perksey commented Nov 23, 2020

Feel free to submit a pull request.

Perksey added a commit that referenced this issue Nov 26, 2020
@Perksey
Fix #355
dbf5696
@Perksey
Copy link
Member

Perksey commented Nov 26, 2020 •
edited
Loading

Fixed in 2.0 Build 601 (will be in 2.0 Preview 4)

@Perksey Perksey closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Windowing bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nablabla @Perksey