Skip to content

ALContext IsExtensionPresent is missing the device parameter #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Perksey opened this issue Nov 7, 2020 · 1 comment
Closed

ALContext IsExtensionPresent is missing the device parameter #343

Perksey opened this issue Nov 7, 2020 · 1 comment
Labels
area-OpenAL bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone
2.0

Comments

@Perksey
Copy link
Member

Perksey commented Nov 7, 2020

Summary

Likely caused by SilkTouch implementing the NativeAPI signature instead of an actually valid signature. Will need to add an overload that has a Device* parameter. Haven't decided what to do with the deviceless overload yet. Discovered by @Nihlus. PRs welcome.

Steps to reproduce

  • Platform: Desktop (Linux, x64, Radeon RX Vega, VEGA10, DRM 3.35.0, 5.4.0-52-generic, LLVM 10.0.0)
  • Framework Version: .NET Core 3.1
  • API: OpenAL/ALC
  • API Version: unknown
  • Silk.NET Version: 2.0.0-preview2

Comments

PRs welcome.
@Perksey Perksey added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers area-OpenAL labels Nov 7, 2020
@Perksey Perksey added this to the 2.0 milestone Nov 7, 2020
Perksey added a commit that referenced this issue Nov 14, 2020
@Perksey
Fix #343
4fa00ba
Perksey added a commit that referenced this issue Nov 15, 2020
@Perksey @HurricanKai
iOS Support (#346)
2c49f07 
* Preprocessor directives for BuildTools

* Add ExcludeFromOverrideAttribute

* Working prototype

* Update to the new attribute

* Don't need override type

* Use ExcludeFromOverride, regenerate bindings, fix OpenCL

* Fix #343

* Incremental Slots

* unsafe

Co-authored-by: Kai Jellinghaus <contact@kaij.tech>
@Perksey
Copy link
Member Author

Perksey commented Nov 17, 2020

Fixed in 2.0 Preview 3

@Perksey Perksey closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-OpenAL bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@Perksey