-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Blazor-SignalR configuration updates #27197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
My only minor complaint is that the keep alive interval isn't directly related to the problem and doesn't necessarily need to be changed. If your issue is due to timeouts, then the timeouts can be increased and the keep alive intervals can stay the same. If you do change them then they should be 50% or less of the timeout values, and maybe you do want to change them at the same time as you increase the timeouts in order to reduce bandwidth. |
Thanks @BrennanConroy ... I'll complete the work on this within the next few days ... probably early next week, including updates to address your feedback using your language. I'll ping u back. |
NOTE: NO rush on this. Let's take it up next week if you like, @BrennanConroy. I needed to wait on further JS interop (new API) just a bit longer for another PR that I was going to work this morning. Since I'm pushing that off to Monday, I was able to set it all up this morning.
The base coverage in the Blazor > Fundamentals > SignalR topic didn't change because that's just basic coverage on how to change the properties, no specific guidance is present there.
|
@BrennanConroy ... This looks good. I used your language. I don't think it requires further review. I'll take community feedback on it going forward. |
Fixes #26465
Brennan, this is a bit drafty at the moment, but it's probably worth sorting out the SignalR settings for this before I copy content for multiple versions of the content ... and even across docs, since we probably need these updates for the hosted WASM case, too.
This PR is mostly about addressing Javier's ask at ...
Connection disconnected with error 'Error: Server timeout elapsed without receiving a message from the server.'.
dotnet/aspnetcore#42778 (comment)
There are several permutations of the configuration. Ultimately, I'm trying to cover both hosting models, WebSockets (primary) and Long Polling (fallback), and server/client config for when latency is spawning the reconnection UI.
The critical piece is Lines 754-828 in the Host and Deploy > Server article where the settings to avoid timeouts are covered. After that content is corrected, I'll flesh out a version of it for the WASM article (as a hosted WASM scenario).
I couldn't quite tell from the issue and API exactly which settings are required where. I probably need to prune one or more of them.
Since it might be easier to just look at that bit right here in a comment instead of sorting through all of the doc churn, here it is. If you let me know for this bit what's right, what's wrong, and what's iNsAnE 😵😄 ... I'll update from there and then ping you back later for a full review of the PR.
Those two "For more info ..." cross-links will go back to the Fundamentals > SignalR topic, where the settings are covered in a more general way, not specifically for ping timeout/latency problems. The fundamentals topic will also have cross-links to this Host and deploy coverage.