Skip to content

Wrong placement of flag in command #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Conversation

nnickie23
Copy link
Contributor

Fix the placement of "--no-trunc" flag of docker command

@rndmh3ro
Copy link
Member

rndmh3ro commented Dec 2, 2021

Thanks, the code changes look good! You do need to sign-off your commits, though. Please check here (https://github.com/dev-sec/cis-docker-benchmark/pull/73/checks?check_run_id=4395996667) on how to do this.

Fix the placement of "--no-trunc" flag of docker command

Signed-off-by: nnickie23 <tnkgold97@mail.ru>
@schurzi schurzi added the bug label Feb 25, 2023
@schurzi schurzi changed the title Fix command flag (#72) Wrong placement of flag in command Feb 25, 2023
@schurzi schurzi linked an issue Feb 25, 2023 that may be closed by this pull request
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
@schurzi
Copy link
Contributor

schurzi commented Feb 25, 2023

sorry to let this hang for so long.

I had one minor change, the Docker documentation states a different order of arguments (https://docs.docker.com/engine/reference/commandline/history/)

docker history [OPTIONS] IMAGE

@schurzi schurzi merged commit 0baeeb2 into dev-sec:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong placement of flag in command
3 participants