Skip to content

Add error serialization #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2018
Merged

Add error serialization #59

merged 1 commit into from
Dec 6, 2018

Conversation

danivek
Copy link
Owner

@danivek danivek commented Aug 2, 2018

Proposal of an implementation of error serialization (see #56).

@danivek danivek self-assigned this Aug 2, 2018
@coveralls
Copy link

coveralls commented Aug 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4bc3c24 on serialize-errors into ac11009 on master.

cmelgarejo
cmelgarejo approved these changes Dec 5, 2018
View reviewed changes
Copy link

@cmelgarejo cmelgarejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feature I want to use, you got a green light from me 👍 (not that it matters, but I would ❤️ to use the package instead of my fork 😝)

@danivek
Copy link
Owner Author

danivek commented Dec 6, 2018

Thanks, @cmelgarejo for your review !

@danivek danivek merged commit 65d23fc into master Dec 6, 2018
@danivek danivek deleted the serialize-errors branch April 29, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmelgarejo cmelgarejo cmelgarejo approved these changes

Assignees

@danivek danivek

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danivek @coveralls @cmelgarejo