Update gradle to 7.4.2 #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- nodejs 10 is eol
eygraber
commented
Apr 26, 2022
| ./gradlew shadowJar -p danger-kotlin-library | ||
| ./gradlew build -p danger-kotlin-kts | ||
| ./gradlew build -p danger-kotlin | ||
|
|
||
| uninstall: | ||
| rm -rf $(INSTALL_PATH) | ||
| rm -f $(LIB_INSTALL_PATH)/danger-kotlin.jar | ||
| rm -f $(LIB_FLAT_DIR) | ||
| rm -rf $(LIB_FLAT_DIR) |
There was a problem hiding this comment.
This was causing an error so I fixed it here.
eygraber
commented
Apr 26, 2022
Comment on lines
-2
to
-3
| provided | ||
| compile.extendsFrom provided |
There was a problem hiding this comment.
implementation replaced compile and provided didn't seem to be used in any special way, so I replaced all instances of provided with implementation. Let me know if I was off base here.
eygraber
commented
Apr 26, 2022
| includeJar "org.jetbrains.kotlin:kotlin-main-kts:$versionKotlin" | ||
| } | ||
|
|
||
| shadowJar { | ||
| baseName = 'danger-kotlin-kts' | ||
| getArchiveBaseName().set('danger-kotlin-kts') |
There was a problem hiding this comment.
I didn't set the other properties to '' here because it doesn't look like anything is depending on the version not being in the filename.
|
Most of the changes are coming from updates to the wrapper scripts. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #215