feat: watch() method #101
Closed
feat: watch() method #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilletuzi
changed the title
|
@iamwyza @maxime1992 @todian @Blankarsch @isnob46 @xxxTonixxx Hi everyone, as requesters of this feature, I would greatly appreciate you review this PR to check it would match your needs. Documentation is included in the PR. I'm still not 100% sure it's a good idea, because of the first note included in the doc: client-side storage only makes sense for keeping data when the user leaves the application and comes back later; if you just need to track data when the user stays in the application, you do not need to watch and not even to use client-side storage: you just need a variable/property. |
tonivj5
reviewed
Apr 28, 2019
tonivj5
approved these changes
Apr 28, 2019
Merged
Merged
|
Redone in #108 due to a git issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89, #16 and #4