Skip to content

Feat/ssn table #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 26, 2024
Merged

Conversation

jusdino
Copy link
Collaborator

@jusdino jusdino commented Dec 18, 2024

Description List

  • Added minor improvements to API/Lambda logging to make tracing requests easier
  • Moved SSN/provider_id association records into a separate DynamoDB table
  • Encrypted that table with a very restrictive key
  • Added a resource policy to the table that prevents bulk data read/write
  • Integrated required permissions across license ingest and API query workflows

Testing List

  • bin/run_tests.sh
  • Please manually ETE test by:
    • Deleting all provider data from your sandbox
    • Upload a mock data CSV via the UI, for two different states (requires a user with write permission in two states)
    • Wait ~5 minutes
    • Query for licenses
    • Query for a particular SSN
    • Verify that the provider record has two licenses associated (one for each state)
  • Code review

Closes #
#396

Copy link
Collaborator

@landonshumway-ia landonshumway-ia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the inverted GSI that we will likely want to document the answer to.

@jusdino jusdino requested a review from jlkravitz December 20, 2024 18:38
@jusdino
Copy link
Collaborator Author

jusdino commented Dec 20, 2024

@jlkravitz , this one is ready for you!

@jlkravitz
Copy link
Collaborator

jlkravitz commented Dec 20, 2024

  • review the pull request to get oriented
    • read the description of the pull request, which should summarize the changes made
    • read through every task on the Scrum board that's encompassed by this pull request
    • read the description of the commits that comprise the pull request
  • skim all new code, in the context of existing code, looking for problems (knowing that the vast majority of new code will be covered by tests)
  • review all tests
    • methodically review all new tests for correctness, quality of naming
    • look at code coverage of tests
    • determine what code isn’t tested, review that rigorously
  • review documentation to ensure that it matches changes
  • provide comments on the pull request on GitHub, as necessary
    • for comments that are specific to a particular line of code, comment on those specific lines
    • for comments that are more general, attach the comment to a random line in README.md (as opposed to commenting on the pull request itself), to be able to use GitHub's ability to thread discussions on those comments

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for being so detail-oriented on this one. Few questions/comments.

@jusdino
Copy link
Collaborator Author

jusdino commented Dec 23, 2024

@jlkravitz, alrighty, this one is back in your court.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen This is good to go.

@isabeleliassen isabeleliassen self-requested a review December 26, 2024 16:33
@isabeleliassen isabeleliassen merged commit 8ff3a18 into csg-org:development Dec 26, 2024
4 checks passed
@jusdino jusdino deleted the feat/ssn-table branch December 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants