Skip to content

Hide report generator strong name warning #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarcoRossignoli
Copy link
Collaborator

We use report generator core to help on debugging, it's not signed, we'll suppress warning at project level.

cc: @tonerdo @danielpalme

@danielpalme
Copy link

I will sign ReportGenerator as soon as ImageSharp gets signed (see danielpalme/ReportGenerator#210, SixLabors/ImageSharp#738)

@MarcoRossignoli
Copy link
Collaborator Author

I will sign ReportGenerator as soon as ImageSharp gets signe

Thank's!Keep me updated if you can!

@MarcoRossignoli MarcoRossignoli merged commit 41511a4 into coverlet-coverage:master Sep 16, 2019
@MarcoRossignoli MarcoRossignoli deleted the fixreportgeneratorwarning branch September 16, 2019 08:05
@danielpalme
Copy link

I will sign ReportGenerator as soon as ImageSharp gets signe

Thank's!Keep me updated if you can!

I will notify you (see https://github.com/danielpalme/ReportGenerator/projects/2#card-20977365).
But I don't know when ImageSharp gets signed.

@MarcoRossignoli
Copy link
Collaborator Author

Great thank's!

@danielpalme
Copy link

I was finally able to sign the ReportGenerator DLLs with a strong name.

Release 4.6.0 contains the changes:
https://www.nuget.org/packages/ReportGenerator/4.6.0
https://www.nuget.org/packages/dotnet-reportgenerator-globaltool/4.6.0
https://www.nuget.org/packages/ReportGenerator.Core/4.6.0

@MarcoRossignoli
Copy link
Collaborator Author

Thanks Daniel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants