-
Notifications
You must be signed in to change notification settings - Fork 388
Use Xunit.v3 (latest release) #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f8d57ba
use xunit.v3 for unit tests
Bertk 013feab
cleanup '#pragma warning disable'
Bertk 78807f7
Update publish-coverage-results.yml
Bertk fcdd26d
enabling Microsoft Testing Platform
Bertk e567eea
Merge branch 'xunit.v3' of https://github.com/Bertk/coverlet into xun…
Bertk 0447967
enabling Microsoft Testing Platform for all tests
Bertk bdbe03d
Revert "enabling Microsoft Testing Platform for all tests"
Bertk 4f6a6d3
enable Microsoft Testing Platform for coverlet core tests
Bertk 59c1678
remove filters handled by publish-coverage-results.yml
Bertk 5666085
add test Execute_StateUnderTest_Success()
Bertk adf41b1
fix warning
Bertk eca5e8c
Update package versions to use property references
Bertk 1e09a04
use Microsoft Testing Plaform for coverlet.msbuild.task.tests
Bertk d7d571d
Update projects to .NET 8 and improve CI configurations
Bertk b82996e
small documentation update
Bertk cf354b1
Update changelog, documentation and add helper script `build.sh`
Bertk 8eb7855
disable Microsoft.Testing.Platform for coverlet.msbuild.tasks.tests
Bertk 8ebd2cb
Update NuGet package versions in Directory.Packages.props
Bertk cea59f5
use property XunitV3Version
Bertk 8d9e0db
use property XunitRunnerVisualstudioVersion
Bertk 64635c0
incorporate review comments
Bertk 40148c1
Merge branch 'xunit.v3' of https://github.com/Bertk/coverlet into xun…
Bertk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not supporting
4.6.1
anymore? And nothing <net core 6
? I think we still can instrument the e.g. .NET Core 2.0 projects. But coverlet needs a .NET6 runtime to execute.At least with the
.NET Tool
I think it should still be possible?And can you tell/remind me why we have these constraints on the
collector
andmsbuild
drivers again. I see that they are bothnetstandard2.0
. Is it because of the libraries they are using?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET Framework 4.7.2 is the first version which supports netstandard2.0 and we use nuget packages which require .NET 6.0 runtime. By the way, coverlet.collector.csproj file currently has only netstandard2.0 and we can change this in another PR.
see also current vstest collector example