Skip to content

Invariant CLI output #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daveMueller
Copy link
Collaborator

closes #1263

@daveMueller daveMueller force-pushed the 1263_GermanCultureCLIOuput branch from 680466b to e34c445 Compare December 4, 2021 23:17
@MarcoRossignoli
Copy link
Collaborator

Thx I'll take a look asap

@MarcoRossignoli MarcoRossignoli added the bug Something isn't working label Dec 5, 2021
@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Dec 5, 2021

@daveMueller some reason to not simply update call sites with val.ToString(CultureInfo.InvariantCulture) and avoid new service?

we can create local helper to reuse private string InvariantFormat(double val) => val.ToString(CultureInfo.InvariantCulture);

Or at least an helper to FormattableString.Invariant(value); or call it directly where needed.

Add new service for it looks to me too much, wdyt?

@daveMueller
Copy link
Collaborator Author

I also thought about this and you convinced me now 😉. It's just a habbit of me to write adapters for things like FormattableString.Invariant(value) to increase testability. But I also had in mind that in this case we don't really benefit much from it.

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoRossignoli MarcoRossignoli merged commit 8eaaecb into coverlet-coverage:master Dec 6, 2021
@daveMueller daveMueller deleted the 1263_GermanCultureCLIOuput branch December 6, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage result uses comma instead of dot for decimals
2 participants