-
Notifications
You must be signed in to change notification settings - Fork 388
Empty lines in compiler generated methods #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty lines in compiler generated methods #1023
Conversation
|
/azp run |
Commenter does not have sufficient privileges for PR 1023 in repo coverlet-coverage/coverlet |
Somebody has an idea what went wrong on the macOS Debug build with the integration test |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Mhh OK this is strange. I just disabled 2 integration tests and enabled them back again and now all tests passed. I also don't have any problems when executing the integration tests locally. I guess we should discuss this when someone finds time to review this. Maybe it has something to do with serialization/deserialization speed because I extended the |
@daveMueller I need to deeply check...that new prop serialized could be very big, have you compared before and after size to find out some sort of ratio? |
a9a9e3e
to
b2e71f3
Compare
@MarcoRossignoli I now thought of a better solution. I always assumed the documents list is immutable in
Also thanks for tip with the inprocess debugging. |
@daveMueller is this PR still needed? |
@MarcoRossignoli I will check this again and get back to you. |
I converted this to draft. I look into it again when I have some more free time. |
Partially closes #799