-
Notifications
You must be signed in to change notification settings - Fork 81
all(breaking): Fix typoes and add spell checking workflow #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mossaka
wants to merge
2
commits into
containerd:main
Choose a base branch
from
Mossaka:spell-checking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking changes: - `Throttling` struct field name `throtted_periods` -> `throttled_periods` - `Throttling` struct field name `throtted_time` -> `throttled_time` - `SimpleWriteVistor` -> `SimpleWriteVisitor` This commit also adds a spell checking workflow to the repository. Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
jprendes
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com> Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
jprendes
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mxpv
approved these changes
Mar 12, 2025
@Mossaka this should be good to merge. Could you pls take a look on merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-runc
runc helper
C-runc-shim
Runc shim
C-shim
Containerd shim
C-snapshots
Remote snapshotter
needs update
T-CI
Changes in project's CI
T-docs
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking changes:
Throttling
struct field namethrotted_periods
->throttled_periods
Throttling
struct field namethrotted_time
->throttled_time
SimpleWriteVistor
->SimpleWriteVisitor
This commit also adds a spell checking workflow to the repository.