Revert "feat: 💄 Wrap dsfr css imports in a dsfr layer" #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kaaloo, Thank you for taking the time to come back and reverse this. Keep in mind, for future contribution that you can start by using patch-package to test in your usecase before contributing the patch upstream. |
Yes my excuses, I will definitely be more careful next time! 😊 |
|
No issue at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to revert this PR because my tests have not been conclusive. Indeed, it appears that support of native CSS features such as
@import url("...") layer(layerName)is only slated for webpack 6 which hasn't been released yet. I tried enabling these new features in the latest webpack version 5.99.8 using the
experimental.css: truewebpack config setting but this caused major breakage of our UI.Reverts #400