(fix): accessibility on Select, aria-described-by of <select> should be defined when state is different of default #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be defined when state is different of default
celinegilet
approved these changes
Apr 9, 2025
|
@MBrandone, thank you for making the effor of submitting a PR! |
|
Petite question @garronej, y a t-il quelque chose à faire de mon côté pour que le fix soit déployé dans une nouvelle version du package npm ? |
|
Non, c'est le cas déjà. NB: J'ai repris l'implémentation mais l'output est équivalent: 51f5a9a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ceci est une Pull Request qui effectue la modification proposée dans cette issue : #402
Elle consiste à supprimer l'attribut aria-describedby de l'élément select quand il possède un state à "default", car aucun message informatif dans le DOM lui est associé.