Build cleanup #52
Merged
Build cleanup #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pretty standard for our engines by now.
|
👍 |
| @@ -10,11 +10,12 @@ machine: | |||
|
|
|||
| dependencies: | |||
| override: | |||
| - docker build -t=$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM . | |||
| - echo "no-op" | |||
|
|
|||
added 3 commits
February 16, 2016 17:04
This is best practice for engines now.
wfleming
force-pushed
the
will/cleanup
branch
from
5d14c23 to
70e4fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codeclimate/review a couple things here around organization & building. Just cleaning up & making things a bit more consistent with other engines.