add CI tests #48
Merged
add CI tests #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdallo
reviewed
May 2, 2025
Comment on lines
+6
to
+7
| tags: | ||
| - 'v[0-9]+.[0-9]+.[0-9]+*' |
There was a problem hiding this comment.
Don't we want tests to run on every master commit too? not only releases
|
Yes, see 2 lines above.
…-------- Original Message --------
On 5/2/25 07:41, Eric Dallo wrote:
@ericdallo commented on this pull request.
---------------------------------------------------------------
In [.github/workflows/test.yml](#48 (comment)):
> + tags:
+ - 'v[0-9]+.[0-9]+.[0-9]+*'
Don't we want tests to run on every master commit too? not only releases
—
Reply to this email directly, [view it on GitHub](#48 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AACGFJBHS5YJKRQ33SRX7LD24NRYLAVCNFSM6AAAAAB4HAFNZWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMJRHEYTQNJSGE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Ah I thought that would filter push on master with tag, got it |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Proof it works: frenchy64#1