Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

feat: Adds CGridItem #407

Merged
merged 6 commits into from
Jun 10, 2021
Merged

Conversation

IHIutch
Copy link
Contributor

@IHIutch IHIutch commented Mar 14, 2021

Create a CGridItem like so

Description

Adds CGridItem, modifies some imports/exports of CGrid

Motivation and Context

Consistency with the react lib and greater control over grid items using Chakra consistent props

How Has This Been Tested?

  • Storybook
  • Added new tests

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2021

⚠️ No Changeset found

Latest commit: 8a0b375

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 14, 2021

@IHIutch is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@IHIutch IHIutch changed the title Start adding CGridItem feat(wip): Adds CGridItem Mar 14, 2021
@vercel
Copy link

vercel bot commented Mar 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/biETAkqCpEUXSySkAHWJqct4JVF9
✅ Preview: https://chakra-ui-vue-git-fork-ihiutch-feat-grid-item-chakra-ui.vercel.app

@codebender828
Copy link
Collaborator

Hey @IHIutch !

Thanks for working on this PR. Juat wanted to.check with you if it's still in progress.

The code looks good to me. 👍🏽 The only thing missing here is a couple of tests. A couple of snapshots will suffice here. You can also look at the CGrid.test.js file to see some existing examples of how to test CSS property values on components.

@IHIutch
Copy link
Contributor Author

IHIutch commented Mar 26, 2021

Yep, still in progress. Probably will update this weekend. I'll keep you posted, thanks for checking in!

@IHIutch
Copy link
Contributor Author

IHIutch commented Jun 5, 2021

Wow, long weekend, eh? Anyway.. Updated this with tests and new documentation. Let me know what you think

@IHIutch IHIutch changed the title feat(wip): Adds CGridItem feat: Adds CGridItem Jun 5, 2021
@IHIutch IHIutch marked this pull request as ready for review June 5, 2021 19:02
@codebender828
Copy link
Collaborator

Thanks @IHIutch !

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IHIutch Looks great. Planning a new release tomorrow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants