Skip to content

Resolve: Unable to reference other local json file #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SOHELAHMED7
Copy link
Contributor

@SOHELAHMED7 SOHELAHMED7 commented Dec 19, 2024

I have attempted to create a failing test for #175

And unable to create one.

This test proves that this issue does not exist.

@SOHELAHMED7 SOHELAHMED7 changed the title Draft: Unable to reference other local json file Resolve: Unable to reference other local json file Dec 19, 2024
@SOHELAHMED7 SOHELAHMED7 marked this pull request as ready for review December 19, 2024 13:11
@cebe
Copy link
Owner

cebe commented Feb 7, 2025

would still be good to have it as a test.

@SOHELAHMED7
Copy link
Contributor Author

Fine. Modifying this PR for merging...

@SOHELAHMED7 SOHELAHMED7 marked this pull request as draft February 7, 2025 11:19
@SOHELAHMED7 SOHELAHMED7 changed the title Resolve: Unable to reference other local json file Draft: Unable to reference other local json file Feb 7, 2025
@SOHELAHMED7 SOHELAHMED7 changed the title Draft: Unable to reference other local json file Resolve: Unable to reference other local json file Feb 7, 2025
@SOHELAHMED7 SOHELAHMED7 marked this pull request as ready for review February 7, 2025 11:30
@SOHELAHMED7
Copy link
Contributor Author

This PR is ready for merging

@cebe cebe added this to the 1.8.0 milestone Apr 23, 2025
@cebe cebe merged commit c453d39 into cebe:master Apr 23, 2025
26 checks passed
@cebe
Copy link
Owner

cebe commented Apr 23, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants