fix: fix Surface styling when flex set #4634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question, will the flex-related properties (or other outerLayerStyleProperties) take effect in the inner box? On andriod and web it will be applied to the only box directly. |
BogiKay
force-pushed
the
fix/surface-styling-flex
branch
from
be665c1 to
8e0c8e0
Compare
|
I suspect this PR may have introduced a regression for #3652 When setting See my comment at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR fixes the issue when flex is applied to the Surface component and flex style is re-applied only to outer component, not the nested one, so styles can be broken if e.g
flexandjustifyContentare applied together.Exact repro is provided in #4632
Related issue
Fixes #4632