refactor: drop old arch and cpp templates #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/drop-old-arch-templates
branch
7 times, most recently
from
0d9088e to
c673d3e
Compare
the large number of templates makes it difficult to maintain and test. so this reduces the number of templates: - drop old architecture templates - users can use codegen or older version of crnl - drop cpp templates - our cpp template isn't a pure cpp template, we should eventually have it
satya164
force-pushed
the
@satya164/drop-old-arch-templates
branch
from
c673d3e to
2b8b8d1
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarry
The large number of templates makes it difficult to maintain and test. so this reduces the number of templates:
Test plan
Tested building each template: turbo module, fabric view, nitro module and ran the example app for Android & iOS to verify it works.
compiling for iOS 15.1, but module 'CxxStdlib' has a minimum deployment target of iOS 16.0mrousavy/nitro#422, so had to force the iOS version to make it workBoth of them seem related to XCode 16 and not this change.