Add sidecar containers #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master <> master
Possibility to add sidecars container to the agents pods. e.g: adding a vpn sidecare container, or fluentd sidecar container.
|
Fix #29 |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
chart/values.yaml:63
- [nitpick] The field name 'sideContainers' is somewhat ambiguous. Consider renaming it to 'sidecarContainers' to more clearly reflect its purpose.
sideContainers:
chart/templates/deployment.yaml:31
- [nitpick] Currently, the side containers are injected before the main container definition. If container order is important for your application's behavior or initialization, consider appending them after the primary container.
{{ with .Values.sideContainers }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we required to add sidecar containers to our AzureDevOps agents for VPN connection (this also could be any other stuff like fluentd).
I added the fact to be able to add sidecar containers to deployment
You are free to change the name of the values file.
Waiting for the review