Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

[rewrite] Rewrite 2.x from scratch #519

Merged
merged 2 commits into from
Sep 10, 2020
Merged

[rewrite] Rewrite 2.x from scratch #519

merged 2 commits into from
Sep 10, 2020

Conversation

rennokki
Copy link
Collaborator

@rennokki rennokki commented Sep 10, 2020

Working with the 2.x seemed a difficult job:

  • Replication interfaces and Channel Managers ping-ponged with the ways of storing connections and statistics for current live server
  • No TDD-driven test, some old tests lacked integration tests at all
  • The WebSocket Server's HTTP API endpoints lacked support for horizontal autoscaling
  • Lack of consistency (some methods returned ints, some others promises; now all promises-based methods are returning fulfilled promises)
  • Because of the TDD-driven aspect, we reach better coverage and on-point tests
  • Simpler project tree

Expect a doc update & PR rewrite with the changes to take into consideration when migrating from 1.x to (now beta) 2.x

@rennokki rennokki changed the title Rewrite from scratch 2.x [rewrite] Rewrite 2.x from scratch Sep 10, 2020
@rennokki rennokki changed the base branch from master to 2.x September 10, 2020 20:00
@rennokki rennokki merged commit cf4aaea into 2.x Sep 10, 2020
@rennokki rennokki deleted the rewrite-from-scratch branch September 10, 2020 20:07
@rennokki rennokki mentioned this pull request Sep 10, 2020
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant