Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Make TriggerEventController accept both 'channel' and 'channels'. #1046

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Make TriggerEventController accept both 'channel' and 'channels'. #1046

merged 1 commit into from
Oct 19, 2022

Conversation

madpilot78
Copy link

This is just a backport of a small part of commit fb958fb

It should fix #1041.

The same issue is also reported in pusher/pusher-http-php#351.

This is just a backport of a small part of commit fb958fb
@Wernke96
Copy link

@mpociot can you look at this?

Copy link

@adriangornypl adriangornypl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@madpilot78
Copy link
Author

BTW I think a new release of the 1.x branch should be created afterwards, so this "fix" is available to everyone.

@adriangornypl
Copy link

Definitely a good idea :) Waiting with fingers crossed ^^

@angeljqv
Copy link

This is going to take more time than you imagine

@davideprevosto
Copy link

You. Lifesaver.

Grazie!

@mpociot mpociot merged commit 50f8a1e into beyondcode:1.x Oct 19, 2022
@madpilot78 madpilot78 deleted the Fix_with_pusher-php-server_7.2 branch October 19, 2022 19:53
@tomvo
Copy link

tomvo commented Oct 20, 2022

🙇

@what-the-diff
Copy link

what-the-diff bot commented Oct 20, 2022

  • Ensure that the request has a valid signature
  • If there is only one channel, it will be wrapped in an array to make sure we can iterate over it later on
  • Iterate over all channels and broadcast the event to everyone except for the sender of this request

@tomvo
Copy link

tomvo commented Oct 24, 2022

can this merge be tagged with a new version?

@blackjak231
Copy link

@mpociot Can we expect a new release of 1.x with this fix soon ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants