-
Notifications
You must be signed in to change notification settings - Fork 92
Optional deps humble #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional deps humble #150
Conversation
This is a great solution to the issue. Should we have a ros-XXX option for all current (or recently EOLd) ROS2 distros? The I'm guessing that the fact we're having this conversation indicates that ROS2 systems are a big use case either within BDAI or the broader user base. If that's the case should we have tooling to make it easy to convert ROS messages to |
This is most definitely the case!
I'll @jbarnett-bdai this could be a decent amount of bang for the amount of man-hour bucks put in, IMO. |
OK, Ben was a postdoc in our lab. There's another one by a former student https://github.com/CallumJHays/spatialmath-rospy. The latter has MIT licence, Ben's one has no licence but I can ping Ben and the lab and get them to add a licence. If we do this, I'd like to see it as a separate file, or even submodule, that doesn't cause issues if there is no ROS installed on the platform. |
Hi all, I tried doing the same in an environment with python 3.10 and the installation works correctly, albeit by still forcing the versions matplotlib==3.5.1 and numpy<2. In this sense, I notice that in the build tests the python version on windows stops at 3.10 https://github.com/bdaiinstitute/spatialmath-python/actions/runs/12750545986. I'd suggest to add tests for higher python versions should be added in order to catch this type of errors. |
Previously, we added version pinning by default for
matplotlib
andnumpy
, to avoid conflicts with system-installed packages in ROS2. This PR removes the default version pinning, moving to aros-humble
underproject.optional-dependencies
inpyproject.toml
.Now, to avoid version conflicts under ROS2 (Humble), the package can be installed via
and the
README.md
is updated to reflect this.Tested that:
[ros-humble]
to the installation command enforces ROS-compatible library versions, avoiding conflict;[ros-humble]
installs up-to-date versions of the libraries.