-
Notifications
You must be signed in to change notification settings - Fork 92
[Issue-126] fix several issues with animate #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6dc40ae
to
21f9b56
Compare
2e32897
to
3262923
Compare
3262923
to
cc7398f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable change to me, but I'm not a primary user of the Spatialmath animation tool. I would feel more comfortable if there was infra to unit test, but I'm also not Spatialmath comes with that in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, minor comment.
@@ -104,6 +104,12 @@ def __init__( | |||
# ax.set_zlim(dims[4:6]) | |||
# # ax.set_aspect('equal') | |||
ax = smb.plotvol3(ax=ax, dim=dim) | |||
if dim is not None: | |||
if len(dim) == 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a runtime error that check's for length 2 or 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! added this check in 27fd4aa
Fix several issues related to #126
Example use-cases: