Skip to content

feat: allow specifying arbitrary constraints for local toolchains #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Apr 26, 2025

This adds the ability for local toolchains to have arbitrary constraints set on them.

This allows accomplishing two goals:

  1. Makes it easier to enable/disable them on the command line, instead of having them
    entirely override an existing config and having to comment/uncomment the
    MODULE.bazel file sections.
  2. Allows configuring them so that the repository is never initialized, which avoids
    the repository from being initialized during toolchain resolution, even if it will
    never match because of (1).

@rickeylev rickeylev requested a review from aignas as a code owner April 26, 2025 04:29
@rickeylev rickeylev marked this pull request as draft April 26, 2025 15:20
@rickeylev rickeylev changed the title feat: allow arbitrary target settings for local toolchains feat: allow specifying arbitrary constraints local toolchains Apr 26, 2025
@rickeylev rickeylev marked this pull request as ready for review April 26, 2025 19:05
@rickeylev rickeylev enabled auto-merge April 27, 2025 02:55
@rickeylev rickeylev changed the title feat: allow specifying arbitrary constraints local toolchains feat: allow specifying arbitrary constraints for local toolchains Apr 29, 2025
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add CHANGELOG.md entry to point to the new docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants