fix nullable parameters #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #107 by updating the CI workflow configurations for PHP projects. The changes include updating the Ubuntu runner versions and action versions, adding PHP 8.4 to the test matrix, and enhancing the PHP-CS-Fixer step with additional arguments.
Files not reviewed (3)
- src/Render/LocalSvgRenderer.php: Language not supported
- src/Render/SvgForTheBadgeRenderer.php: Language not supported
- src/UI/Command.php: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/php.yml:25
- Ensure that the addition of the php84 container is supported by adequate tests to verify compatibility.
container: [ "php81", "php82", "php83", "php84" ]
garak
force-pushed
the
fix-deprecated
branch
2 times, most recently
from
68bd4b2 to
dd5eca7
Compare
|
Sadly, testing on PHP 8.4 is not currently possible because phpspec still doesn't support it. Anyway, I added a Docker tag (along with few instructions to create future new tags) |
antonkomarev
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107