Made some properties of Bedrock's Event optional. #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KUrushi
changed the title
calavera
reviewed
Dec 6, 2023
calavera
reviewed
Dec 6, 2023
calavera
suggested changes
Dec 6, 2023
add default value to parameters Co-authored-by: David Calavera <david.calavera@gmail.com>
add default to request_body Co-authored-by: David Calavera <david.calavera@gmail.com>
|
Thank you for your code suggestion! I have applied your suggestion. |
calavera
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When I actually created an Event and started it from a Lambda function, I noticed that some parameters were Nullable.
Agents for Amazon Bedrock takes into account the HTTP Method of the configured schema and sets values for the properties.
So I noticed that, for example, if the GET method is configured in the schema, there is usually no Request body.
I don't know if this is correct because the schema page of the document does not specify whether it is Nullable or not, but I think it is safest to set
parametersandrequest_bodyto Optional.If anyone knows the details, I would appreciate it if you could let me know.
By submitting this pull request