Tag apigw struct fields with proper serde(skip_serializing_if)
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, only some of structs in
apigwmodule hasserde(skip_serializing_if)tagged, therefore, only some of them support serialization properly.This PR adds the aforementioned tag to the rest of the structs in
apigwmodule. This will be useful when a user of the library wants to serialize these structs.Fields to add
serde(skip_serializing_if)referenced fromaws-lambda-golibrary:https://github.com/aws/aws-lambda-go/blob/main/events/apigw.go
By submitting this pull request