Add script to automatically set up a new module #6118
Conversation
zoewangg
added
the
no-changelog
scripts/setup-new-module
Outdated
|
|
||
| # Check if module already exists | ||
| if grep -q "<module>$module_path</module>" "$root_pom"; then | ||
| echo "Module already exists in root pom.xml. Skipping." |
There was a problem hiding this comment.
When would this happen and is this something that should be an error?
There was a problem hiding this comment.
It could happen when the user has already set up some files manually because they may not know this script exist when they created the new module
scripts/setup-new-module
Outdated
| fi | ||
|
|
||
| echo "" | ||
| echo "Module setup complete! Please review the changes and complete any manual steps mentioned above." |
There was a problem hiding this comment.
I'm not sure how much output this produces, but it might be good to collect the required manual steps and provide them all together here so they are less likely to be missed. (feel free to ignore if its never much output).
There was a problem hiding this comment.
There's actually no manual steps anymore :) Will update it
| print(f"Using SDK version: {sdk_version}") | ||
|
|
||
| with open(pom_path, 'w') as f: | ||
| f.write(f'''<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Nit: put the start of text on new line for readability and consistency with other text below
|
Motivation and Context
Add script to automatically set up a new module based on the checklist.