Remove extra va_end in err_add_error_vdata #2364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should va_end(args_copy), but the function should not va_end(args). The caller is responsible for that one. As I understand it, this in benign: in every target we care about, va_end is a no-op. Bug: 379096238 Change-Id: I063c775ecd496edc1b5c69c027d1dd9a04f578d1 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74088 Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
- Coverage 78.81% 78.80% -0.02%
==========================================
Files 621 621
Lines 108418 108417 -1
Branches 15399 15398 -1
==========================================
- Hits 85455 85442 -13
- Misses 22293 22305 +12
Partials 670 670 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
changed the title
skmcgrail
approved these changes
Apr 28, 2025
andrewhop
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should va_end(args_copy), but the function should not va_end(args). The caller is responsible for that one.
As I understand it, this in benign: in every target we care about, va_end is a no-op.
Bug: 379096238
Change-Id: I063c775ecd496edc1b5c69c027d1dd9a04f578d1
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74088
Auto-Submit: David Benjamin davidben@google.com
Reviewed-by: Adam Langley agl@google.com
Commit-Queue: Adam Langley agl@google.com
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.