-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(ec2): support AWS::EC2::VPCEndpointService SupportedIpAddressTypes property #33877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): support AWS::EC2::VPCEndpointService SupportedIpAddressTypes property #33877
Conversation
d93c9ef
to
0d54a3e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33877 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6938 6938
Branches 1170 1170
=======================================
Hits 5716 5716
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/** | ||
* IP address types supported for VPC endpoint service. | ||
*/ | ||
export enum IpAddressType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I see in CFN doc two more new values dualstack
, not-specified
along with this. Are these recently added? Not a blocker and should be good to merge. Just curious if the CFN resource schema has these values as well.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
Supporting a new L1 property
AWS::EC2::VPCEndpointService
Description of changes
Added a new property -
supportedIpAddressTypes
- to theVpcEndpointService
construct. It takes a list ofIpAddressType
enums.Describe any new or updated permissions being added
None
Description of how you validated changes
Updated integ test to use the new property and deployed successfully.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license