Skip to content

aws-rds: Add support for engineLifecycleSupport configuration in L2/L3 constructs #33859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
mMeijden opened this issue Mar 21, 2025 · 3 comments · Fixed by #33902
Closed
2 tasks

aws-rds: Add support for engineLifecycleSupport configuration in L2/L3 constructs #33859

mMeijden opened this issue Mar 21, 2025 · 3 comments · Fixed by #33902
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mMeijden
Copy link

mMeijden commented Mar 21, 2025

Describe the feature

We would like to be able to configure the engineLifecycleSupport through the L2 constructs. This is currently unsupported and can only be set by using the propertyOverride function

const CfnDBCluster = this.node.defaultChild as CfnDBCluster;
CfnDBCluster.addPropertyOverride('EngineLifecycleSupport', 'open-source-rds-extended-support-disabled');

Use Case

We have use cases where we explicitly disable/enable the engine lifecycle support.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.CfnDBCluster.html#enginelifecyclesupport

Proposed Solution

I'm not entirely sure where this property can be properly implemented as this is only applicable to RDS for MySQL and RDS for PostgreSQL and on Aurora it is configured on the cluster.
Perhaps extending the interfaces provided to tge DatabaseClusterEngine. auroraMysql(),DatabaseClusterEngine. auroraPostgres() ,DatabaseInstanceEngine.mysql(), DatabaseInstanceEngine.postgres() functions to accept an optional parameter.

For example:

engine: rds.DatabaseClusterEngine.auroraPostgres(
  {
  	version: rds.AuroraPostgresEngineVersion.VER_17_2,
  	engineLifecycleSupport: EngineLifecycleSupport.OPEN_SOURCE_RDS_EXTENDED_SUPPORT_DISABLED // explicitly disabled. by default set to enabled.
  }
),

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.185.0

Environment details (OS name and version, etc.)

any

@mMeijden mMeijden added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 21, 2025
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Mar 21, 2025
@pahud
Copy link
Contributor

pahud commented Mar 21, 2025

Yes, we should consider to expose this to the surface. Please help us prioritize with 👍 and we welcome PRs.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 21, 2025
@mergify mergify bot closed this as completed in #33902 Apr 1, 2025
@mergify mergify bot closed this as completed in c0f8d29 Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
shikha372 pushed a commit to shikha372/aws-cdk that referenced this issue Apr 4, 2025
### Issue # (if applicable)

Closes aws#33859.

### Reason for this change

Cloudformation supports dor configuring engine lifecycle support for RDS and Aurora. 

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.CfnDBCluster.html#enginelifecyclesupport

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/extended-support.html


### Description of changes

- Define `EngineLifecycleSupport`
- Add `engineLifecycleSupport` prop to `DatabaseClusterBaseProps`

### Describe any new or updated permissions being added

None

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants