Skip to content

chore(ci): add missing dependency to build docs #6717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025
Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #6692

Summary

This PR add the missing dependency required to build the docs.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner May 25, 2025 07:40
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label May 25, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2025
@leandrodamascena leandrodamascena requested review from dreamorosi and removed request for anafalcao May 25, 2025 07:40
@leandrodamascena leandrodamascena linked an issue May 25, 2025 that may be closed by this pull request
1 task
@leandrodamascena leandrodamascena self-assigned this May 25, 2025
@github-actions github-actions bot added the internal Maintenance changes label May 25, 2025
@leandrodamascena
Copy link
Contributor Author

Fixed @hjgraca @dreamorosi. Pls approve this PR.

Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (e343782) to head (2d1796c).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6717      +/-   ##
===========================================
+ Coverage    96.08%   96.09%   +0.01%     
===========================================
  Files          254      254              
  Lines        12177    12177              
  Branches       904      904              
===========================================
+ Hits         11700    11702       +2     
+ Misses         374      373       -1     
+ Partials       103      102       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dreamorosi
Copy link
Contributor

I think you should/could remove the "contributing" pages from the LLM txt output in the mkdocs.yml.

They don't help customers build better functions in their projects and only take up tokens in the context.

I had asked @hjgraca to remove them in the TS repo and I think we should do the same here.

Will approve right after, just tag me again.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label May 25, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 25, 2025
Copy link

@leandrodamascena
Copy link
Contributor Author

I think you should/could remove the "contributing" pages from the LLM txt output in the mkdocs.yml.

They don't help customers build better functions in their projects and only take up tokens in the context.

I was thinking more about giving customers more context about things like the local environment - make pr an others. But you have a point about using tokens that makes more sense than I was thinking.

Done.

@leandrodamascena
Copy link
Contributor Author

@dreamorosi

@leandrodamascena leandrodamascena merged commit f0f8d68 into develop May 25, 2025
15 of 24 checks passed
@leandrodamascena leandrodamascena deleted the ci/fix-docs branch May 25, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add llms.txt to documentation site
2 participants