Skip to content

fix(datastore): memory leak in ModelSyncedEventEmitter #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

5d
Copy link
Contributor

@5d 5d commented May 3, 2024

Issue #

#3510

Description

  • capturing self with weak reference in filter operator.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from a team as a code owner May 3, 2024 21:16
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 3, 2024 21:16 — with GitHub Actions Inactive
@5d 5d merged commit cd5545b into main May 7, 2024
72 checks passed
@5d 5d deleted the 5d/issue-3510 branch May 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants