-
Notifications
You must be signed in to change notification settings - Fork 341
Switch on testing for the book; fix #6 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wow, thanks already for that :). |
I haven't tested the changes to the travis build but otherwise I think this is ready. |
This will fail ;). What's missing is a |
I'm not sure how to fix this latest error from |
Note that this fixes #89. |
- cargo check --all --benches --bins --examples --tests | ||
- cargo test --all | ||
- if ![[ -n "$BUILD_BOOK" ]]; then cargo check --all --benches --bins --examples --tests && cargo test --all; fi | ||
- if [[ -n "$BUILD_BOOK" ]]; then cargo test --all --benches --bins --examples --tests; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had to modify the travis config to where, when the book should be built, we don't run cargo check
but instead just run cargo test
.
This might cause ci to not fail as quickly on the linux build but the problem is that running cargo check
followed by cargo test
produces two entries for async_std
in ./target/debug/deps
which then causes mdbook test
to fail when trying to resolve extern crate async_std
.
I don't know of another way to fix that issue. If this is an acceptable workaround then I think this PR is good to go.
This needs to be updated to remove all uses of |
I've removed the |
Added missing `spawn_and_log_error` function declaration
Run the tests with the following:
The
-L
flag is needed so that external crates can be resolved in the tests.