Skip to content

fix: incorrect expr for server and repo-server telemetry in Grafana dashboard #22659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pandvan
Copy link

@pandvan pandvan commented Apr 14, 2025

This follows and correct #21098: fix was correct, but done in wrong panels.
Now all panels with telemetry data make use of service name as its job name for the filter.
It also remove some duplicate panel IDs.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@pandvan pandvan requested a review from a team as a code owner April 14, 2025 08:56
Copy link

bunnyshell bot commented Apr 14, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.03%. Comparing base (faf0073) to head (ad0c920).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22659      +/-   ##
==========================================
+ Coverage   55.99%   56.03%   +0.03%     
==========================================
  Files         343      343              
  Lines       57536    57535       -1     
==========================================
+ Hits        32219    32239      +20     
+ Misses      22668    22657      -11     
+ Partials     2649     2639      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pandvan pandvan force-pushed the dashboard-typo branch 4 times, most recently from 3008a7f to 68fa6b3 Compare April 14, 2025 10:08
…ashboard

Signed-off-by: pandvan <prog.pawz@gmail.com>
Signed-off-by: pandvan <prog.pawz@gmail.com>
Copy link

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants