Skip to content

DocC setup #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2022
Merged

DocC setup #42

merged 9 commits into from
Aug 6, 2022

Conversation

yim-lee
Copy link
Member

@yim-lee yim-lee commented Jul 28, 2022

No description provided.

@yim-lee
Copy link
Member Author

yim-lee commented Jul 28, 2022

Need #41 for 5.6 and 5.7 builds.

@yim-lee yim-lee requested review from ktoso and tomerd July 28, 2022 01:10
@yim-lee yim-lee force-pushed the docc branch 2 times, most recently from 39b0c21 to e14744a Compare July 28, 2022 01:55
@@ -0,0 +1,193 @@
# ``ServiceDiscovery``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wrap over the Package.swift style to be for the "old versions", but otherwise LGTM~!

@tomerd
Copy link
Member

tomerd commented Aug 2, 2022

We should wrap over the Package.swift style to be for the "old versions", but otherwise LGTM~!

I mentioned this on the other PR, this is something @fabianfett and myself tried with aws-lambda-runtime and had trouble with. I cant remember all the details but @fabianfett had issues making the "old versions" work reliably and we ended up adding a 5.6 version as the PR does currently.

@ktoso
Copy link
Member

ktoso commented Aug 3, 2022

I guess let's figure it out over here and then apply to all repos: apple/swift-statsd-client#36
Commented over there a bit

@yim-lee yim-lee requested a review from tomerd August 5, 2022 22:02
@@ -0,0 +1,36 @@
// swift-tools-version:5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.4?

@@ -0,0 +1,36 @@
// swift-tools-version:5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.5?

Copy link
Member

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice <3

@@ -0,0 +1,36 @@
// swift-tools-version:5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.4?

@yim-lee yim-lee merged commit bd49e03 into apple:main Aug 6, 2022
@yim-lee yim-lee deleted the docc branch August 6, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants