-
Notifications
You must be signed in to change notification settings - Fork 22
DocC setup #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocC setup #42
Conversation
Need #41 for 5.6 and 5.7 builds. |
39b0c21
to
e14744a
Compare
@@ -0,0 +1,193 @@ | |||
# ``ServiceDiscovery`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wrap over the Package.swift style to be for the "old versions", but otherwise LGTM~!
I mentioned this on the other PR, this is something @fabianfett and myself tried with aws-lambda-runtime and had trouble with. I cant remember all the details but @fabianfett had issues making the "old versions" work reliably and we ended up adding a 5.6 version as the PR does currently. |
I guess let's figure it out over here and then apply to all repos: apple/swift-statsd-client#36 |
@@ -0,0 +1,36 @@ | |||
// swift-tools-version:5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.4?
@@ -0,0 +1,36 @@ | |||
// swift-tools-version:5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice <3
@@ -0,0 +1,36 @@ | |||
// swift-tools-version:5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.4?
No description provided.