swipe proffers use of delta_x, delta_y instead of end_x, end_y which … #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are marked as deprecated
jlipps
requested changes
Oct 12, 2016
There was a problem hiding this comment.
Looks like some stylistic changes are required, see the Travis failure at: https://travis-ci.org/appium/ruby_lib/builds/166993568
KazuCocoa
added a commit
to KazuCocoa/ruby_lib
that referenced
this pull request
Nov 17, 2016
KazuCocoa
added a commit
to KazuCocoa/ruby_lib
that referenced
this pull request
Nov 17, 2016
KazuCocoa
added a commit
that referenced
this pull request
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are marked as deprecated
Also addresses Issue #293