Skip to content

Fix remaining rubocop issues #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2015
Merged

Fix remaining rubocop issues #329

merged 1 commit into from
Apr 29, 2015

Conversation

bootstraponline
Copy link
Member

This reduces the rubocop issues to zero. I haven't tested yet.

@bootstraponline
Copy link
Member Author

I fixed the broken flaky tool, android tests are passing at 100%.

$ flake 3 android
Recording Video: false
Running all android tests 3x
flaky.txt: {"android"=>"lib/android/specs/"}
Globbing: /ruby_lib/android_tests/lib/android/specs/**/*.rb

 android/element/alert  ✖ ✓
 android/element/button  ✓
 android/element/generic  ✓
 android/element/text  ✓
 android/element/textfield  ✓
 android/helper  ✓
 android/patch  ✓
 common/device  ✓
 common/device_touchaction  ✓
 common/element/window  ✓
 common/helper  ✓
 common/patch  ✓
 common/version  ✓
 common/web_context  ✓
 ./driver  ✓
 ./install  ✓

16 Tests

Success (16):
android/element/alert, runs: 2, pass: 1, fail: 1 
android/element/button, runs: 1, pass: 1, fail: 0 
android/element/generic, runs: 1, pass: 1, fail: 0 
android/element/text, runs: 1, pass: 1, fail: 0 
android/element/textfield, runs: 1, pass: 1, fail: 0 
android/helper, runs: 1, pass: 1, fail: 0 
android/patch, runs: 1, pass: 1, fail: 0 
common/device, runs: 1, pass: 1, fail: 0 
common/device_touchaction, runs: 1, pass: 1, fail: 0 
common/element/window, runs: 1, pass: 1, fail: 0 
common/helper, runs: 1, pass: 1, fail: 0 
common/patch, runs: 1, pass: 1, fail: 0 
common/version, runs: 1, pass: 1, fail: 0 
common/web_context, runs: 1, pass: 1, fail: 0 
./driver, runs: 1, pass: 1, fail: 0 
./install, runs: 1, pass: 1, fail: 0 

Finished in 7 mins 36 secs
Apr 28  9:25 pm -  9:33 pm
4/28/2015   16  0   16  100
--

@bootstraponline
Copy link
Member Author

Once appium/appium#5018 is resolved then I'll be able to verify all the iOS tests pass.

bootstraponline added a commit that referenced this pull request Apr 29, 2015
Fix remaining rubocop issues
@bootstraponline bootstraponline merged commit 1b88060 into master Apr 29, 2015
@bootstraponline bootstraponline deleted the rubocop branch April 29, 2015 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant