CollectionDataProviderInterface does not play well with generators

[greg0ire]

I tried implementing it with generators, and it worked just fine... until... I implemented a second.

The problem is here:

core/src/DataProvider/ChainCollectionDataProvider.php

Lines 38 to 48 in 020dbf2

	public function getCollection(string $resourceClass, string $operationName = null)
	{
	foreach ($this->dataProviders as $dataProvider) {
	try {
	return $dataProvider->getCollection($resourceClass, $operationName);
	} catch (ResourceClassNotSupportedException $e) {
	continue;
	}
	}
	}
	}

Here is what my implementation looks like:

    public function getCollection(string $resourceClass, string $operationName = null)
    {
        if ($resourceClass !== Person::class) {
            throw new ResourceClassNotSupportedException();
        }

       yield $aPerson;

The ChainCollectionDataProvider will loop over my providers, and will immediatly return the generator returned by the first data provider because no code is executed until the generator is used inside a foreach, which happens later in the code, outside the try / catch block.

The solution would be to introduce a supports method in the interface.

[meyerbaptiste]

Fixed by #1429.