[hotfix] Fix reduce scan.manifest.parallelism not take effect #5297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Mar 17, 2025
| @@ -36,7 +36,7 @@ public class ManifestReadThreadPool { | |||
| createCachedThreadPool(Runtime.getRuntime().availableProcessors(), THREAD_NAME); | |||
|
|
|||
| public static synchronized ThreadPoolExecutor getExecutorService(@Nullable Integer threadNum) { | |||
| if (threadNum == null || threadNum <= executorService.getMaximumPoolSize()) { | |||
| if (threadNum == null || threadNum >= executorService.getMaximumPoolSize()) { | |||
There was a problem hiding this comment.
If you want increase thread Num, this becomes not work now...
There was a problem hiding this comment.
maybe we can remove check threadNum <= executorService.getMaximumPoolSize() condition? increase or reduce both ok.
There was a problem hiding this comment.
Why do you need to reduce the number of threads?
There was a problem hiding this comment.
We find there are 64 manifest thread when doing full manifest merge, it takes up a lot of memory, we want to relieve it by reducing the thream num.
There was a problem hiding this comment.
Maybe when the thread number is less than max pool size, you can introduce a SemaphoredDelegatingExecutor to wrap shared Executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When reduce
scan.manifest.parallelismparameter, it does not take effect.Tests
API and Format
Documentation