Skip to content

feat: support region highlight #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v5
Choose a base branch
from

Conversation

moayuisuda
Copy link
Collaborator

@moayuisuda moayuisuda commented Apr 21, 2025

Checklist
  • npm test passes
  • documents are updated
Description of change
  1. 参考 feat: element select support custom region group #6724 ,增加 region 参数使 elementHighligh 支持在空白处触发,达到类似 v4 版本 active-region 的效果,解决 柱状图数值差距过大导致交互难度较大,是否可以鼠标移入当前行时触发交互 #6582
  2. 定义多交互共存时优先级,让多交互之间效果可共存,冲突时根据优先级排序,解决 [Feat]: 支持多个交互可以共存 #6803
    Apr-21-2025 23-14-35

文档

image

@moayuisuda moayuisuda force-pushed the feat/chart-element-highlight-region branch from 8bc9b64 to 9266201 Compare April 21, 2025 16:04
@moayuisuda moayuisuda force-pushed the feat/chart-element-highlight-region branch from 9266201 to fa2b60e Compare April 21, 2025 16:20
@coveralls
Copy link

coveralls commented Apr 21, 2025

Pull Request Test Coverage Report for Build 14616790373

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 54 of 63 (85.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 86.693%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/interaction/utils.ts 31 33 93.94%
src/interaction/elementHighlight.ts 16 23 69.57%
Totals Coverage Status
Change from base Build 14576015618: -0.07%
Covered Lines: 10747
Relevant Lines: 12010

💛 - Coveralls

@interstellarmt
Copy link
Contributor

新增region触发确实解决了数值过小无法点击的问题,关于elementHighlight和elementSelect的新参数,补充一下文档和示例吧,关于state优先级的也可以在state文档里进行补充

@moayuisuda moayuisuda changed the title <WIP> Feat/chart element highlight region feat: support region highlight Apr 23, 2025
@interstellarmt
Copy link
Contributor

region参数的有空补充一下示例~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants