Skip to content

Remove pass test #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 23, 2024
Merged

Remove pass test #5

merged 10 commits into from
Mar 23, 2024

Conversation

mubarak23
Copy link

Remove pass test PR
tests/ui/cfg/cfg-panic-abort.rs
tests/ui/fmt/format-args-capture.rs
tests/ui/panic-runtime/link-to-abort.rs
tests/ui/panic-runtime/abort-link-to-unwinding-crates.rs
tests/ui/panic-runtime/abort.rs
tests/ui/statics/issue-91050-1.rs
tests/ui/statics/issue-91050-2.rs
tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs
tests/ui/panic-runtime/lto-abort.rs

@mubarak23
Copy link
Author

Sorry, i close the other PR by mistake

@antoyo
Copy link
Owner

antoyo commented Mar 21, 2024

Some tests are failing, so please add them back to the file.

@mubarak23
Copy link
Author

I will look for them and add them back

@mubarak23
Copy link
Author

add the following back to the list

  • format-args-capture.rs
  • tests/ui/cfg/cfg-panic-abort.rs

Co-authored-by: antoyo <antoyo@users.noreply.github.com>
@antoyo
Copy link
Owner

antoyo commented Mar 23, 2024

There are still a few failures, as you can see here.
Please add back these failures.

@mubarak23
Copy link
Author

Add the following back to the list

  • tests/ui/panic-runtime/abort-link-to-unwinding-crates.rs
  • tests/ui/panic-runtime/abort.rs
  • tests/ui/panic-runtime/lto-abort.rs

@@ -30,7 +29,7 @@ tests/ui/mir/mir_drop_order.rs
tests/ui/mir/mir_let_chains_drop_order.rs
tests/ui/oom_unwind.rs
tests/ui/panic-runtime/abort-link-to-unwinding-crates.rs
tests/ui/panic-runtime/abort.rs
tests/ui/panic-runtime/abort.rs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing space.

@antoyo
Copy link
Owner

antoyo commented Mar 23, 2024

From what I can see in the logs, it seems like these tests pass and should be removed:

  • tests/ui/binding/fn-arg-incomplete-pattern-drop-order.rs
  • tests/ui/macros/rfc-2011-nicer-assert-messages/all-expr-kinds.rs
  • tests/ui/runtime/rt-explody-panic-payloads.rs

Did you try removing them?

@mubarak23
Copy link
Author

The list I shared at the start of this PR was the one I removed. I will review the logs and remove any that have passed and I may have missed.

@antoyo
Copy link
Owner

antoyo commented Mar 23, 2024

Please add tests/ui/binding/fn-arg-incomplete-pattern-drop-order.rs to failing-lto-tests.txt as it seems this test only fails with LTO enabled.

@mubarak23
Copy link
Author

Alright

@antoyo antoyo merged commit 51eae7e into antoyo:master Mar 23, 2024
@antoyo
Copy link
Owner

antoyo commented Mar 23, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants