-
Notifications
You must be signed in to change notification settings - Fork 4
Remove pass test #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, i close the other PR by mistake |
Some tests are failing, so please add them back to the file. |
I will look for them and add them back |
add the following back to the list
|
Co-authored-by: antoyo <antoyo@users.noreply.github.com>
There are still a few failures, as you can see here. |
Add the following back to the list
|
tests/failing-ui-tests.txt
Outdated
@@ -30,7 +29,7 @@ tests/ui/mir/mir_drop_order.rs | |||
tests/ui/mir/mir_let_chains_drop_order.rs | |||
tests/ui/oom_unwind.rs | |||
tests/ui/panic-runtime/abort-link-to-unwinding-crates.rs | |||
tests/ui/panic-runtime/abort.rs | |||
tests/ui/panic-runtime/abort.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing space.
From what I can see in the logs, it seems like these tests pass and should be removed:
Did you try removing them? |
The list I shared at the start of this PR was the one I removed. I will review the logs and remove any that have passed and I may have missed. |
Please add |
Alright |
Thanks for your contribution! |
Remove pass test PR
tests/ui/cfg/cfg-panic-abort.rs
tests/ui/fmt/format-args-capture.rs
tests/ui/panic-runtime/link-to-abort.rs
tests/ui/panic-runtime/abort-link-to-unwinding-crates.rs
tests/ui/panic-runtime/abort.rs
tests/ui/statics/issue-91050-1.rs
tests/ui/statics/issue-91050-2.rs
tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs
tests/ui/panic-runtime/lto-abort.rs