Skip to content

v4.0.0 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 164 commits into from
Dec 16, 2018
Merged

v4.0.0 #487

merged 164 commits into from
Dec 16, 2018

Conversation

angularsen
Copy link
Owner

@angularsen angularsen commented Sep 27, 2018

4.0.0 Release

This PR will serve as the list of items to complete and it will be updated to show the progress before finally merged into master when completed. We all have busy schedules, so if you want to help move this work forward then that is much appreciated!

The main theme is to reduce binary size

In two years it has grown from 280 kB to 1.4 MB and a lot of it is due to unnecessary syntactic sugar with many method overloads for various number types and nullable types - for every of our 800+ units! It simply adds up to a big total.

These items are chosen from #180, trying to include as many of the low hanging fruits as possible, while still keeping the list short and realistic to complete in a reasonably short time - we are all busy in our daily lives. We can always have more major version bumps later than trying to perfect it all now.

Feature complete before November, merged before mid-December

I would like to aim for a "beta" pre-release nuget sometime in October with all the items completed, so we can have some time to test it before releasing the final, stable 4.0.0 version before Christmas holidays.
We should have the work items list more or less final before Monday, October 8th.

Changes

Added

  • UnitSystem with a different meaning, now defines the base units for a unit system (Si unit system #524)

Removed

Changed

Renamed

Fixed

  • Search for any TODO comments in the code to address, remove comment and either fix or create issue (5d24432)
  • Update README with v4 changes Update README with v4 changes #498
  • Do not try/catch in UnitConverter.Try-methods (Try methods without catch #506)
  • Do not try/catch in Length.TryParse() and for other quantities (Try parse #507)
  • Add/update changelog in wiki for v4 with some summary copied from this issue, some v3 to v4 migration instructions and briefly explain why some stuff were removed

Milestones

  • Finalize work items list (Monday, October 8)
  • Release 4.0.0-beta1, feature complete (Wednesday, October 31)
  • Show release notes and upgrade guide when upgrading to 4.x nuget, if possible
  • Release 4.0.0 (Monday, December 17)

@angularsen angularsen self-assigned this Sep 27, 2018
tmilnthorp and others added 26 commits September 28, 2018 09:36
…NET Framwork version is obsolete and will be removed in the future, but the WRC version is not and would be a breaking change to remove.
* Changing target frameworks to .NET standard 2.0 and .NET 4.0

* Updating build script
This is no longer used, was used when manually deploying nugets with scripts.
It incorrectly bumped from -alpha1 to -alpha12.
4.0.0-alpha1 not a valid assembly version or
file version.
Too many to fix right now.
We should address this, but right now this is just a
big distraction and spam.
Added issue to look at this later:
#495
* Fix SingularName for some units in VolumeFlow

* On second thought, MillionUsGallonsPerDay is appropiate since millions already defines a plurality
@angularsen
Copy link
Owner Author

Reverted #550 in 71bc0a8.

Per discussion in:
#560 (comment)

We can't justify this change just yet, we need to know if the majority of our userbase expects this new Temperature arithmetic or the old one.

@angularsen
Copy link
Owner Author

4.0.0-beta2 released.

This reverts commit f28d009.

It turns out I forgot I did it this way, because
skip_branch_with_pr:true setting prevented branch build - and
PR builds do not deploy nugets.
angularsen and others added 2 commits December 10, 2018 12:12
@angularsen angularsen changed the title v4.0.0 (Work In Progress) v4.0.0 Dec 16, 2018
@angularsen angularsen merged commit 87dc3c7 into master Dec 16, 2018
@angularsen angularsen deleted the v4 branch December 16, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants