-
Notifications
You must be signed in to change notification settings - Fork 391
v4.0.0 #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v4.0.0 #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olute equality check.
…NET Framwork version is obsolete and will be removed in the future, but the WRC version is not and would be a breaking change to remove.
* Changing target frameworks to .NET standard 2.0 and .NET 4.0 * Updating build script
This is no longer used, was used when manually deploying nugets with scripts.
It incorrectly bumped from -alpha1 to -alpha12.
4.0.0-alpha1 not a valid assembly version or file version.
Too many to fix right now.
We should address this, but right now this is just a big distraction and spam. Added issue to look at this later: #495
* Fix SingularName for some units in VolumeFlow * On second thought, MillionUsGallonsPerDay is appropiate since millions already defines a plurality
Check certs in to repo so it's easier for others to build this.
Build x86 as x64 seems to fail.
New release 2018-11-09
It's just cumbersome to merge into release/v4, it will only publish if we do indeed bump the version numbers.
This reverts commit b0361ba. Per discussion in: #560 (comment) We can't justify this change just yet, we need to know if the majority of our userbase expects this new Temperature arithmetic or the old one.
Per discussion in: We can't justify this change just yet, we need to know if the majority of our userbase expects this new Temperature arithmetic or the old one. |
4.0.0-beta2 released. |
We no longer create them.
This reverts commit f28d009. It turns out I forgot I did it this way, because skip_branch_with_pr:true setting prevented branch build - and PR builds do not deploy nugets.
Fix negative FeetInches and StonePounds with negative values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0.0 Release
This PR will serve as the list of items to complete and it will be updated to show the progress before finally merged into
master
when completed. We all have busy schedules, so if you want to help move this work forward then that is much appreciated!The main theme is to reduce binary size
In two years it has grown from 280 kB to 1.4 MB and a lot of it is due to unnecessary syntactic sugar with many method overloads for various number types and nullable types - for every of our 800+ units! It simply adds up to a big total.
These items are chosen from #180, trying to include as many of the low hanging fruits as possible, while still keeping the list short and realistic to complete in a reasonably short time - we are all busy in our daily lives. We can always have more major version bumps later than trying to perfect it all now.
Feature complete before November, merged before mid-December
I would like to aim for a "beta" pre-release nuget sometime in October with all the items completed, so we can have some time to test it before releasing the final, stable 4.0.0 version before Christmas holidays.
We should have the work items list more or less final before Monday, October 8th.
Changes
Added
Removed
[Obsolete]
, such asVolumeUnit.Teaspoon
(Removing obsolete quantity units #490)From
factory methods (Removing nullable methods from quantity classes as well as extension … #483)Length2d
, replaced byArea
(Remove Length2d #501)UnitSystem
, should useUnitSystem.Default
instead (Remove UnitSystem static methods #496)ToString()
methods (Removing unit conversion from ToString methods. ToUnit must be called… #546)Changed
FromMeters()
(Do not allow NaN or Infinity #502, see Support NaN #176 (comment))ToString()
methods (Removing unit conversion from ToString methods. ToUnit must be called… #546)Renamed
Fixed
Length.TryParse()
and for other quantities (Try parse #507)Milestones
Show release notes and upgrade guide when upgrading to 4.x nuget, if possible