Skip to content

Split WRC #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Split WRC #463

merged 3 commits into from
Jul 17, 2018

Conversation

tmilnthorp
Copy link
Collaborator

More work towards #409. Splitting ToString and Parse methods into the appropriate .NET and WRC code generators.

@tmilnthorp tmilnthorp requested a review from angularsen July 12, 2018 21:03
@angularsen
Copy link
Owner

As mentioned on gitter, you need to push your version commit to origin/master first so that this PR doesn't introduce it.

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that, this looks good

@tmilnthorp tmilnthorp merged commit 13432f4 into angularsen:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants