Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Power has a very wide range of usable values (examples) so I'm not sure where exactly we'd want to draw the line.
There's also a tolerance issue that came up in the femtowatts unit tests: using
double
to store femtowatts leads to rounding/representation issues.I was thinking about this previously and I think
decimal
might be a better backing datatype because it can exactly represent powers of 10 because it's a decimal floating point type (double
is binary floating point). It would make sense to use it since we're mainly concerned with SI units which are powers of 10, however it's a major breaking change anddecimal
is less efficient for calculations...