Skip to content

Remove SupportsSIUnitSystem => true property overrides #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

Remove SupportsSIUnitSystem => true property overrides #1537

merged 4 commits into from
Apr 11, 2025

Conversation

lipchev
Copy link
Collaborator

@lipchev lipchev commented Apr 11, 2025

fixes #1463

@lipchev
Copy link
Collaborator Author

lipchev commented Apr 11, 2025

Duplicate of #1534 which got deleted when release/v6 went away..

As expected, there are only the

ElectricApparentEnergy
ElectricReactiveEnergy
FuelEfficiency

which override this property (and also [Skip] the corresponding tests). The only other tests that are skipped are for the BaseUnit_HasSIBase (as noted in the linked issue).

@angularsen angularsen merged commit 46663ea into angularsen:master Apr 11, 2025
1 check was pending
@angularsen angularsen changed the title Removing the SupportsSIUnitSystem => true property overrides Remove SupportsSIUnitSystem => true property overrides (#1537) Apr 11, 2025
@angularsen angularsen changed the title Remove SupportsSIUnitSystem => true property overrides (#1537) Remove SupportsSIUnitSystem => true property overrides Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angularsen angularsen angularsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The SupportsSIUnitSystem property should no be needed
2 participants
@lipchev @angularsen